Member Domain1D::asArray (const double *soln) const

Despite the method's name, data are copied; the intent is to access data directly in future revisions, where a non-const version will be implemented.

Member HMWSoln::satPressure (double T) override

This is probably not implemented correctly. The stability of the salt should be added into this calculation. The underlying water model may be called to get the stability of the pure water solution, if needed.

Member LatticeSolidPhase::getMoleFractions (double *const x) const

This method shadows but does not override Phase::getMoleFractions(). The LatticeSolidPhase class should be revised to avoid needing to override the methods for getting composition. See https://github.com/Cantera/cantera/issues/1310 for additional information.

Class MolalityVPSSTP

Make two solvent minimum fractions. One would be for calculation of the non-ideal factors. The other one would be for purposes of stoichiometry evaluation. the stoichiometry evaluation one would be a 1E-13 limit. Anything less would create problems with roundoff error.

Class Phase

Specify that the input mole, mass, and volume fraction vectors must sum to one on entry to the set state routines. Non-conforming mole/mass fraction vectors are not thermodynamically consistent. Moreover, unless we do this, the calculation of Jacobians will be altered whenever the treatment of non- conforming mole fractions is changed. Add setState functions corresponding to specifying mole numbers, which is actually what is being done (well one of the options, there are many) when non- conforming mole fractions are input. Note, we realize that most numerical Jacobian and some analytical Jacobians use non-conforming calculations. These can easily be changed to the set mole number setState functions.

Class PlasmaPhase

Implement electron Boltzmann equation solver to solve EEDF. https://github.com/Cantera/enhancements/issues/127

Member ThermoPhase::phaseOfMatter () const

Needs to be implemented for all phase types. Currently only implemented for PureFluidPhase.

Class Transport

Provide a general mechanism to store the gradients of state variables within the system.